search

FSGModding / FSG_Mod_Assistant

Farming Simulator 22 Mod Manager.
https://fsgmodding.github.io/FSG_Mod_Assistant/
ISC License
74 stars 10 forks source link

[BUG] Disabling older FS does not disable XML file checking #214

Closed KITT3000 closed 7 months ago

KITT3000 commented 8 months ago

Is there an existing issue for this?

Current Behavior

After setting up collections for FS22 and, for example, FS19 (assigning the gameSetttings.xml file) and disabling multi-game support (but the collection for FS19 was still enabled and the data was not deleted), the program tries to continue checking collections for FS19. I noticed this problem after deleting the files from "My Games/FarmingSimulator2019", and the program's log showed an entry about the inability to load the gameSettings.xml file from the "FarmingSimulator2019" folder, although I checked that the "Multiple games" option was disabled, but I enabled it and the data for FS19 was completed and this collection was enabled.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- Mod Assistant Version: 3.4.1
- OS: Win10 22H2
- Virtualized: No

Anything else?

No response

jtsage commented 8 months ago

Oh, nice catch. Corrected for the next release

jtsage commented 8 months ago

Fwiw, if you find the error messages annoying, you can turn multi-mode back on, toggle that game version off, and then turn off multi-mode again. I just missed the check of the "umbrella" flag :)

jtsage commented 8 months ago

If you are feeling particularly adventurous, I just pushed a 3.5.0-RC1 pre-release that includes this fix (and in all honesty probably adds a bunch of bugs, we shall see :) )