FSGModding / FSG_Mod_Assistant

Farming Simulator 22 Mod Manager.
https://fsgmodding.github.io/FSG_Mod_Assistant/
ISC License
74 stars 10 forks source link

[BUG] Small thing - no warning for failed file move operation. #247

Closed onehandclapping closed 1 month ago

onehandclapping commented 4 months ago

Is there an existing issue for this?

Current Behavior

When attempting to move a mod to another collection where that mod already exists there is no warning when the move fails.

Expected Behavior

Just a dialog that says "Move Failed" or some such.

Steps To Reproduce

No response

Environment

- Mod Assistant Version:4.05
- OS:W10
- Virtualized:No

Anything else?

No response

jtsage commented 4 months ago

which move method? (from a "regular" collection, or from a "favorite" or "holding pen" collection? or drag-and-drop?) The behavior on all of those is slightly different.

For instance, the holding pen one should just do it anyway, overwriting the existing.

From a standard collection, it should sort of warn you - it'll be in the list of things to move, along with a checkbox to overwrite anyway.

But I will do some testing and make sure it is working as intended, thanks!

onehandclapping commented 3 months ago

Sorry for the late update, my 3070 failed and had to be replaced (by a 4070 wahoo).

Just a simple move from one "regular" to another. Selecting one or more mods and then clicking the "Move To" on the right.

jtsage commented 3 months ago

sorry for the delay, been busy. I'm not sure I can replicate this

2024-06-22 13_50_16-FSG Mod Assistant

This is a file that already exists where I want to move it - if I don't hit the check mark, it does nothing. If I do, it overwrites the file as expected. But you are correct that there is no user-facing acknowledgement that (in this case) "1 file(s) will be skipped". I could add something like that text to the button probably

jtsage commented 3 months ago

added a bit that says how many will be affected.

2024-06-22 14_17_41-FSG Mod Assistant

2024-06-22 14_17_46-FSG Mod Assistant

jtsage commented 1 month ago

this is fixed in the testing version, there is visual feedback if anything failed.