FSIBT / PyMCNP

Python tools for MCNP
https://pymcnp.readthedocs.io/en/latest/
Other
6 stars 0 forks source link

Stop tracking version.py with git #4

Closed MicahGale closed 1 week ago

MicahGale commented 1 week ago

I noticed that setuptools-scm is being used for versioning, and the version.py file is being tacked by git. This is a very bad idea. This is because the software version depends on the git SHA1 hash, and the git SHA1 hash depends on the version. This is type of cicular hashing can't be handled by SHA1. This why all of the versions are for "dirty" releases and never for clean working tree.

I would recommend removing the file from git, and then ignoring it in .gitignore.