FSLogix / Invoke-FslShrinkDisk

This script will shrink a FSLogix Disk to its minimum possible size
MIT License
155 stars 55 forks source link

Fixed issue where the script would fail when 'Optimize Drives' service is not running or disabled. #14

Closed msft-jasonparker closed 4 years ago

msft-jasonparker commented 4 years ago

This is a great piece of work. I found this issue when it failed to run. The error was ambiguous due to it getting created from inside the runspace. I also realized the Export-CSV cmdlet was missed the -NoTypeInformation parameter which provides cleaner output. Lastly, while the CSV output is nice, I added the import of the log file to the end and output it in a table so you don't have to go hunt for the results.

Happy to discuss these changes and hope it helps.

//Jason

JimMoyle commented 4 years ago

Closing as pull request was redone