Due to set_exc_info momoko2 does not work on Tornado 3.x

FSX / momoko

Wraps (asynchronous) Psycopg2 for Tornado.

http://momoko.61924.nl/

Other

363 stars 73 forks source link

Closed friedcell closed 9 years ago

friedcell commented 9 years ago

I see two options:

require tornado 4.x for momoko2 [affects docs only]
check for set_exc_info (and set_exception_info from concurrent.futures>=2.2.0?) existence before use [needs code update + tests]

Noticed while selectively upgrading packages on a project, did not find a notice in docs.

haizaar commented 9 years ago

Well, momoko 2.x explicitly requires tornado >= 4.0.0 in setup.py. Where else do you suggest to add notes?

friedcell commented 9 years ago

Saw that after posting the comment. I'd say in the Important notice in readme - I can create a PR if needed.

haizaar commented 9 years ago

Sure, go on with PR please.

haizaar commented 9 years ago

Fixed by #119