NamedTupleCursor factory test is executed even if MOMOKO_TEST_HSTORE is disabled - Githubissues

FSX / momoko

Wraps (asynchronous) Psycopg2 for Tornado.

http://momoko.61924.nl/

Other

364 stars 73 forks source link

NamedTupleCursor factory test is executed even if MOMOKO_TEST_HSTORE is disabled #159

Closed rmedaer closed 5 years ago

rmedaer commented 6 years ago

The unit test test_cursor_factory_with_extensions is testing that NamedTupleCursor factory is working with both hstore and json. However, if MOMOKO_TEST_HSTORE is disabled we should only test json !

A quick fix would be to split the unit test in:

test_cursor_factory_with_json_extension to test JSON
test_cursor_factory_with_hstore_extension to test HSTORE extension and add the following decorator @unittest.skipIf(not test_hstore, "Skipping test as requested")

Is it OK for you ? Would you like that I make a pull request with it ?

haizaar commented 6 years ago

Good point. Indeed, please go ahead with pull request if you can.