search

FSX / momoko

Wraps (asynchronous) Psycopg2 for Tornado.
http://momoko.61924.nl/
Other
364 stars 73 forks source link

Tornado 5.0 support #161

Closed noamkush closed 5 years ago

haizaar commented 6 years ago

Hi Noam,

Please make sure the unittests are passing first.

@MrShiny608 raised quite a valid concern on asynio compatibility (I'm not sure why he seems to have deleted his comment). I think it has to be addressed, particularly since Tornado 5.0 focuses on asyncio compatibility.

P.S. I've also updated Travis matrix as per your suggestion. Thank you for that.

noamkush commented 6 years ago

I tried looking into the failing test and it looks like the test relies on the old add_done_callback implementation, but I'm not familiar enough with the code to fix the test. I'm not sure it's easily fixable at all. I've spent a few hours on this with no success. Regarding asyncio compatibility, I don't think the comment was correct (and I'm guessing MrShiny608 realized that after commenting), if you take a look at tornado's future_set_exc_info implementation.

stalkerg commented 6 years ago

Even without this patch my project working fine with Tornado5/async/await and Momoko.

noamkush commented 6 years ago

That just means you haven't reached any of the set_exc_info uses

noamkush commented 5 years ago

It would have been nicer to merge this with credit but thanks anyway.

haizaar commented 5 years ago

You code wan't merge-able - didn't pass tests, didn't cater for other things like setup.py, etc. But it definitely provided inspiration, so thank you for that.