momoko not working with tornado 4.0

[martinslabber]

Just thought I'll play with latest tornado. Seem that some of the upstream tornado changes (gen.Task is now a function not a class) has broken Momoko. Hope this bug report can help with the fix.

(ve3_t4)➜ momoko git:(master) python setup.py test Using psycopg2 running test running egg_info creating Momoko.egg-info writing dependency_links to Momoko.egg-info/dependency_links.txt writing top-level names to Momoko.egg-info/top_level.txt writing requirements to Momoko.egg-info/requires.txt writing Momoko.egg-info/PKG-INFO writing manifest file 'Momoko.egg-info/SOURCES.txt' reading manifest file 'Momoko.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' writing manifest file 'Momoko.egg-info/SOURCES.txt' running build_ext Traceback (most recent call last): File "setup.py", line 58, in 'Topic :: Database :: Front-Ends' File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/distutils/core.py", line 149, in setup dist.run_commands() File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/distutils/dist.py", line 955, in run_commands self.run_command(cmd) File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/distutils/dist.py", line 974, in run_command cmd_obj.run() File "/Users/martinslabber/Documents/coding/momoko/ve3_t4/lib/python3.4/site-packages/setuptools/command/test.py", line 138, in run self.with_project_on_sys_path(self.run_tests) File "/Users/martinslabber/Documents/coding/momoko/ve3_t4/lib/python3.4/site-packages/setuptools/command/test.py", line 118, in with_project_on_sys_path func() File "/Users/martinslabber/Documents/coding/momoko/ve3_t4/lib/python3.4/site-packages/setuptools/command/test.py", line 164, in run_tests testLoader = cks File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/main.py", line 92, in init self.parseArgs(argv) File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/main.py", line 139, in parseArgs self.createTests() File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/main.py", line 146, in createTests self.module) File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/loader.py", line 146, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/loader.py", line 146, in suites = [self.loadTestsFromName(name, module) for name in names] File "/usr/local/Cellar/python3/3.4.0_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/loader.py", line 105, in loadTestsFromName module = import('.'.join(parts_copy)) File "/Users/martinslabber/Documents/coding/momoko/momoko/tests.py", line 44, in import momoko File "/Users/martinslabber/Documents/coding/momoko/momoko/momoko/init.py", line 15, in from .connection import Pool, Connection File "/Users/martinslabber/Documents/coding/momoko/momoko/momoko/connection.py", line 33, in from .utils import log File "/Users/martinslabber/Documents/coding/momoko/momoko/momoko/utils.py", line 28, in class Op(gen.Task): TypeError: function() argument 1 must be code, not str (ve3_t4)➜ momoko git:(master) pip freeze Momoko==1.1.3 certifi==14.05.14 psycopg2==2.5.3 tornado==4.0

Using Python 3.4.0 on Mac OS X 10.9.4 Steps to reproduce:

• Created a new virtualenv.
• Pip install tornado
• git checkout momoko
• pip install checkedout momoko
• run test

Quite sure it is related to this upstream change: https://github.com/tornadoweb/tornado/commit/518ecf8370643d5bced8fdf48db4cadcd03b7fba

[agates]

I can confirm this issue. I thought I was going crazy until I noticed the new tornado release ;).

[haizaar]

Guys, please test the master and tell me if it works for you.

This one is to help you: pip install -e git://github.com/FSX/momoko.git#egg=Momoko

[martinslabber]

A quick test confirms that it works. Thanks for the quick fix.

[haizaar]

I'm thankful to this bug to know that people actually use momoko :)