search

FStarLang / fstar-mode.el

Emacs support for F*
Apache License 2.0
67 stars 17 forks source link

Add tadmit to list of risky symbols #128

Closed klinvill closed 1 year ago

cpitclaudel commented 1 year ago

I'd prefer to have a merge by an active maintainer since I haven't followed the latest languages developments — the implementation is good though.

klinvill commented 1 year ago

On a little further reflection, I added the other admit and magic tactics to the list of risky syntax as well. @mtzguido are there tactics that I missed or do these additions look pretty complete to you? If they look complete, would you be willing to merge this PR (as per Clément's comment above)?

mtzguido commented 1 year ago

Looks good to me! I suppose set_guard_policy Drop is another risky invocation, but neither symbol is unsafe on its own.. so I would leave this as-is.

Merging then, thanks @klinvill and @cpitclaudel!