search

FStarLang / fstar-mode.el

Emacs support for F*
Apache License 2.0
67 stars 17 forks source link

#79, Lexical argument shadows the dynamic variable #80

Closed andreas-roehler closed 6 years ago

cpitclaudel commented 6 years ago

Thanks. But why do you want to rename string?

andreas-roehler commented 6 years ago

On 08.11.2017 21:05, Clément Pit-Claudel wrote:

Thanks. But why do you want to rename |string|?

Assume the warning comes for this:

string is a built-in function in ‘src/character.c’.

(string &rest CHARACTERS)

Concatenate all the argument characters and make the result a string.

andreas-roehler commented 6 years ago

After all this warnings seems wrong in the very sense of term. However, might be useful not to name arguments like keywords or symbols used otherwise. So think the patch still makes sense.

cpitclaudel commented 6 years ago

Assume the warning comes for this:

That assumption is incorrect: variables and functions don't live in the same namespace, as ELisp is a Lisp 2.

Can you just run M-x find-variable string?

andreas-roehler commented 6 years ago

On 09.11.2017 15:02, Clément Pit-Claudel wrote:

Assume the warning comes for this:

That assumption is incorrect: variables and functions don't live in the same namespace, as ELisp is a Lisp 2.

Can you just run |M-x find-variable string|?

string is a variable defined in ‘coq.el’. Its value is nil

cpitclaudel commented 6 years ago

Thanks. That was a bug in proof general; it was fixed a while ago (by me ^^) You can just update PG and you'll be good.