search

FTB-Gamepedia / FTB-Wiki-Issue-Tracker

Issue tracking (and hopefully squashing) for the FTB Wiki
http://ftb.gamepedia.com
1 stars 0 forks source link

Translation Reviewer adding/removing #7

Closed elifoster closed 9 years ago

elifoster commented 9 years ago

People cannot be removed from the Translation Reviewer group. Sysops should be able to do this.

Telshin commented 9 years ago

Should be fixed

retep998 commented 9 years ago

I am a sysop and I am unable to remove people from the Translation Reviewer group.

elifoster commented 9 years ago

@Telshin You did not fix it http://puu.sh/eaHmn/0d81f03028.png

Telshin commented 9 years ago

Alrighty. We'll have to see why the custom groups are still misbehaving. Thanks!

Sent from my iPhone

On Jan 6, 2015, at 6:40 PM, Eli Foster notifications@github.com wrote:

@Telshin You did not fix it http://puu.sh/eaHmn/0d81f03028.png

— Reply to this email directly or view it on GitHub.

Alexia commented 9 years ago

The FlaggedRevs code by default limits sysops(Adminstrators) to only add or remove the editor and autoreview groups. Unfortunately this is very over reaching on the part of the FlaggedRevs extension code base since it prevents normal sysop group functionality. We can simply nuke these lines from FlaggedRevs.config.php. Would that be fine?

Special:Userrights settings

Basic rights for Sysops

$wgAddGroups['sysop'][] = 'editor'; // promote to basic reviewer (established editors) $wgRemoveGroups['sysop'][] = 'editor'; // demote from basic reviewer (established editors) $wgAddGroups['sysop'][] = 'autoreview'; // promote to basic auto-reviewer (semi-trusted users) $wgRemoveGroups['sysop'][] = 'autoreview'; // demote from basic auto-reviewer (semi-trusted users)

elifoster commented 9 years ago

I'm not sure what this has to do with the Translate extension.

noahm commented 9 years ago

Disregard previous FlaggedRevs comment. The issue should now be completely resolved as of 5 minutes ago.

elifoster commented 9 years ago

Indeed it is.