search

FTBTeam / FTB-App

Electron, Vue2, and Tailwind based frontend system for the FTB App; a new Modpack launcher for FTB and Curse modpacks.
https://feed-the-beast.com/app
GNU Lesser General Public License v2.1
86 stars 22 forks source link

fix: use better title for productName #1014

Closed MindTooth closed 7 months ago

MindTooth commented 7 months ago
Screenshot 2023-11-27 at 15 16 07 Screenshot 2023-11-27 at 15 18 57

I noticed on macOS that the name was a bit off. Changing productName solved this.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

MindTooth commented 7 months ago

I think this broke and you have https://github.com/FTBTeam/FTB-App/issues/1025. Because the following lines are hardcoded. Also, it seems hardcoded to release/mac, but when building for arm, the path is release/mac-arm64.

https://github.com/FTBTeam/FTB-App/blob/1375ba067c48d0dae847eddf2d04be1c0e5734e7/subprocess/ftbapp.install4j#L39-L75

MindTooth commented 7 months ago

Commit for changing the paths: https://github.com/MindTooth/FTB-App/commit/cf659d864d7b6b0bf2f22f1b6fb4514724608c13

But, personally, I think reverting it for now is the best. Obviously this was not tested good enough. 😔

I also created a MR: https://github.com/FTBTeam/FTB-App/pull/1026