search

FTBTeam / FTB-App

Electron, Vue2, and Tailwind based frontend system for the FTB App; a new Modpack launcher for FTB and Curse modpacks.
https://feed-the-beast.com/app
GNU Lesser General Public License v2.1
86 stars 22 forks source link

Remove hardcoded default parameter G1GC #1051

Open pucgenie opened 6 months ago

pucgenie commented 6 months ago

Fixes #684 . G1 garbage collector is Java 17's default. Doesn't fix hardcoded vanilla-copied parameter handling.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

MinetaS commented 2 months ago

Old modpacks may not use Java 17.

https://github.com/FTBTeam/FTB-App/blob/86d919d5e912e15683e89c82186a6e93700d4261/subprocess/src/main/java/net/creeperhost/creeperlauncher/pack/InstanceLauncher.java#L455-L468

It will be better to add MOJANG_DEFAULT_ARGS flags before adding jvmArgs so that end users can override these flags.