FTBTeam / FTB-App

Electron, Vue2, and Tailwind based frontend system for the FTB App; a new Modpack launcher for FTB and Curse modpacks.
https://feed-the-beast.com/app
GNU Lesser General Public License v2.1
92 stars 26 forks source link

Fixed megabyte calculation in valueAsByteReadable() #1084

Closed bryce-schultz closed 6 months ago

bryce-schultz commented 7 months ago

The previous code used the calculation 1024 1000 as the size of a megabyte. I fixed this to be 1024 1024 and put it in a named constant for easier code readability.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

MichaelHillcox commented 6 months ago

Thanks for this <3