FTBTeam / FTB-App

Electron, Vue2, and Tailwind based frontend system for the FTB App; a new Modpack launcher for FTB and Curse modpacks.
https://feed-the-beast.com/app
GNU Lesser General Public License v2.1
86 stars 22 forks source link

Can't add mods to unlocked modpack (download hangs) #1106

Open hvdklauw opened 2 months ago

hvdklauw commented 2 months ago

What Operating System

Windows 11

Debug Code

FTB-DBGRIWADUJINI

Describe the bug

Just hangs on the download screen on 0% progress.

The debug log shows a null pointer exeption at the bottom:

java.util.concurrent.CompletionException: java.lang.NullPointerException
    at java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source) ~[?:?]
    at java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source) ~[?:?]
    at java.util.concurrent.CompletableFuture$AsyncRun.run(Unknown Source) ~[?:?]
    at java.util.concurrent.CompletableFuture$AsyncRun.exec(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinPool.scan(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) ~[?:?]
Caused by: java.lang.NullPointerException
    at java.util.Objects.requireNonNull(Unknown Source) ~[?:?]
    at net.creeperhost.creeperlauncher.data.modpack.ModpackVersionModsManifest$Mod.getCurseSlug(ModpackVersionModsManifest.java:87) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.util.CurseMetadataCache.getCurseMeta(CurseMetadataCache.java:68) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.pack.Instance.getMods(Instance.java:558) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.install.ModInstaller.resolve(ModInstaller.java:90) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.handlers.instances.InstanceInstallModHandler.handle(InstanceInstallModHandler.java:50) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.handlers.instances.InstanceInstallModHandler.handle(InstanceInstallModHandler.java:18) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.handlers.IMessageHandler.handle(IMessageHandler.java:10) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.WebSocketHandler.lambda$handleMessage$0(WebSocketHandler.java:161) ~[launcher-86d919d5e9-all.jar:?]
    ... 7 more

All the logs: https://pste.ch/uxorabokiy

Steps to reproduce

Download FTB builders paradise 2 Unlock it Add a mod (create addon or callable horse) See it hang and nothing happening.

Expected behaviour

For the mod to be downloaded and added to the modpack

Screenshots

No response

Additional information

https://pste.ch/uxorabokiy

LoneStar- commented 2 months ago

Windows 11 Having the same issues trying to install mods to any instance, progress just stays at 0%. Previous version Overwolf/FTB launcher 1.25.7 worked fine, new version 1.25.8 does not download and install individual mods to existing mod packs.

[19:57:00] [ForkJoinPool-1-worker-3/INFO] [net.creeperhost.creeperlauncher.pack.Instance]: Building instance mods list.. [19:57:00] [ForkJoinPool-1-worker-3/INFO] [net.creeperhost.creeperlauncher.pack.Instance]: List built 254 mods. [19:57:01] [ModVersionCache 12/ERROR] [net.creeperhost.creeperlauncher.util.ModVersionCache]: Error whilst querying mod from ram cache. com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalStateException: Failed to query mod manifest for: 247007 at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2055) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache.get(LocalCache.java:3966) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3989) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4950) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.ModVersionCache.lambda$queryMod$0(ModVersionCache.java:118) ~[launcher-86d919d5e9-all.jar:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?] at java.lang.Thread.run(Unknown Source) ~[?:?] Caused by: java.lang.IllegalStateException: Failed to query mod manifest for: 247007 at net.creeperhost.creeperlauncher.util.ModVersionCache$2.load(ModVersionCache.java:56) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.ModVersionCache$2.load(ModVersionCache.java:50) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3533) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2282) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2159) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2049) ~[launcher-86d919d5e9-all.jar:?] ... 8 more Caused by: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected a long but was BOOLEAN at line 26 column 21 path $.updated at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:397) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.Gson.fromJson(Gson.java:1227) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.Gson.fromJson(Gson.java:1137) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.Gson.fromJson(Gson.java:1107) ~[launcher-86d919d5e9-all.jar:?] at net.covers1624.quack.gson.JsonUtils.parse(JsonUtils.java:92) ~[launcher-86d919d5e9-all.jar:?] at net.covers1624.quack.gson.JsonUtils.parse(JsonUtils.java:61) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.data.mod.ModManifest.queryManifest(ModManifest.java:76) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.data.mod.ModManifest.queryManifest(ModManifest.java:63) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.ModVersionCache$2.load(ModVersionCache.java:54) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.ModVersionCache$2.load(ModVersionCache.java:50) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3533) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2282) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2159) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2049) ~[launcher-86d919d5e9-all.jar:?] ... 8 more Caused by: java.lang.IllegalStateException: Expected a long but was BOOLEAN at line 26 column 21 path $.updated at com.google.gson.stream.JsonReader.nextLong(JsonReader.java:973) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.internal.bind.TypeAdapters$11.read(TypeAdapters.java:331) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.internal.bind.TypeAdapters$11.read(TypeAdapters.java:323) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.readIntoField(ReflectiveTypeAdapterFactory.java:212) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$FieldReflectionAdapter.readField(ReflectiveTypeAdapterFactory.java:433) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:393) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.Gson.fromJson(Gson.java:1227) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.Gson.fromJson(Gson.java:1137) ~[launcher-86d919d5e9-all.jar:?] at com.google.gson.Gson.fromJson(Gson.java:1107) ~[launcher-86d919d5e9-all.jar:?] at net.covers1624.quack.gson.JsonUtils.parse(JsonUtils.java:92) ~[launcher-86d919d5e9-all.jar:?] at net.covers1624.quack.gson.JsonUtils.parse(JsonUtils.java:61) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.data.mod.ModManifest.queryManifest(ModManifest.java:76) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.data.mod.ModManifest.queryManifest(ModManifest.java:63) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.ModVersionCache$2.load(ModVersionCache.java:54) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.ModVersionCache$2.load(ModVersionCache.java:50) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3533) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2282) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2159) ~[launcher-86d919d5e9-all.jar:?] at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2049) ~[launcher-86d919d5e9-all.jar:?] ... 8 more [19:57:16] [ForkJoinPool-1-worker-127/INFO] [net.creeperhost.creeperlauncher.install.ModInstaller]: Resolving install of mod 446870 version 4299157 [19:57:17] [ForkJoinPool-1-worker-127/INFO] [net.creeperhost.creeperlauncher.pack.Instance]: Building instance mods list.. [19:57:17] [ForkJoinPool-1-worker-127/ERROR] [net.creeperhost.creeperlauncher.api.WebSocketHandler]: Error handling message java.util.concurrent.CompletionException: java.lang.NullPointerException at java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncRun.run(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncRun.exec(Unknown Source) ~[?:?] at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) ~[?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source) ~[?:?] at java.util.concurrent.ForkJoinPool.scan(Unknown Source) ~[?:?] at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) ~[?:?] at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) ~[?:?] Caused by: java.lang.NullPointerException at java.util.Objects.requireNonNull(Unknown Source) ~[?:?] at net.creeperhost.creeperlauncher.data.modpack.ModpackVersionModsManifest$Mod.getCurseSlug(ModpackVersionModsManifest.java:87) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.util.CurseMetadataCache.getCurseMeta(CurseMetadataCache.java:68) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.pack.Instance.getMods(Instance.java:558) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.install.ModInstaller.resolve(ModInstaller.java:90) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.api.handlers.instances.InstanceInstallModHandler.handle(InstanceInstallModHandler.java:50) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.api.handlers.instances.InstanceInstallModHandler.handle(InstanceInstallModHandler.java:18) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.api.handlers.IMessageHandler.handle(IMessageHandler.java:10) ~[launcher-86d919d5e9-all.jar:?] at net.creeperhost.creeperlauncher.api.WebSocketHandler.lambda$handleMessage$0(WebSocketHandler.java:161) ~[launcher-86d919d5e9-all.jar:?] ... 7 more

shutter-germany commented 1 month ago

same here. Tried to Install Tetra for the Direwolf20 1.20 pack.

[12:21:06.481] [ForkJoinPool-1-worker-4/INFO] [net.creeperhost.creeperlauncher.install.ModInstaller]: Resolving install of mod 289712 version 5236744
[12:21:07.417] [ForkJoinPool-1-worker-4/INFO] [net.creeperhost.creeperlauncher.pack.Instance]: Building instance mods list..
[12:21:07.420] [ForkJoinPool-1-worker-4/ERROR] [net.creeperhost.creeperlauncher.api.WebSocketHandler]: Error handling message
java.util.concurrent.CompletionException: java.lang.NullPointerException
    at java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source) ~[?:?]
    at java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source) ~[?:?]
    at java.util.concurrent.CompletableFuture$AsyncRun.run(Unknown Source) ~[?:?]
    at java.util.concurrent.CompletableFuture$AsyncRun.exec(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinPool.scan(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) ~[?:?]
    at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) ~[?:?]
Caused by: java.lang.NullPointerException
    at java.util.Objects.requireNonNull(Unknown Source) ~[?:?]
    at net.creeperhost.creeperlauncher.data.modpack.ModpackVersionModsManifest$Mod.getCurseSlug(ModpackVersionModsManifest.java:87) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.util.CurseMetadataCache.getCurseMeta(CurseMetadataCache.java:68) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.pack.Instance.getMods(Instance.java:558) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.install.ModInstaller.resolve(ModInstaller.java:90) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.handlers.instances.InstanceInstallModHandler.handle(InstanceInstallModHandler.java:50) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.handlers.instances.InstanceInstallModHandler.handle(InstanceInstallModHandler.java:18) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.handlers.IMessageHandler.handle(IMessageHandler.java:10) ~[launcher-86d919d5e9-all.jar:?]
    at net.creeperhost.creeperlauncher.api.WebSocketHandler.lambda$handleMessage$0(WebSocketHandler.java:161) ~[launcher-86d919d5e9-all.jar:?]
    ... 7 more

Same error also while using the update all mods button in an unlocked modpack.

coldfusion818 commented 1 month ago

I'm having the same issue, when trying to add a mod to an existing modpack or a custom instance.

debug.log

LoneStar- commented 1 month ago

OK, I kinda found a work around for this issue. If I go to "AppData\Local\Overwolf\Extensions\cmogmmciplgmocnhikmphehmeecmpaggknkjlbag" and delete the 1.25.8 folder, app downloads and installs mods fine.

Note: The "cmogmmciplgmocnhikmphehmeecmpaggknkjlbag" folder will be different from what's on your PC. If you are running the Overwolf launcher, right click the FTB shortcut > properties > click shortcut tab and look at the target field.

You should have something like "C:\Program Files (x86)\Overwolf\OverwolfLauncher.exe" -launchapp cmogmmciplgmocnhikmphehmeecmpaggknkjlbag -from-startmenu".

In above command, "cmogmmciplgmocnhikmphehmeecmpaggknkjlbag" would be your FTB extension folder, go in and delete the 1.25.8 folder and you should be able to download and install mods to existing mod pack. One drawback, you will have to delete this folder every time you want to install a new mod. I have created a batch file that automatically deletes the folder then launches the FTB app.

BestBucko commented 1 month ago

OK, I kinda found a work around for this issue. If I go to "AppData\Local\Overwolf\Extensions\cmogmmciplgmocnhikmphehmeecmpaggknkjlbag" and delete the 1.25.8 folder, app downloads and installs mods fine.

Note: The "cmogmmciplgmocnhikmphehmeecmpaggknkjlbag" folder will be different from what's on your PC. If you are running the Overwolf launcher, right click the FTB shortcut > properties > click shortcut tab and look at the target field.

You should have something like "C:\Program Files (x86)\Overwolf\OverwolfLauncher.exe" -launchapp cmogmmciplgmocnhikmphehmeecmpaggknkjlbag -from-startmenu".

In above command, "cmogmmciplgmocnhikmphehmeecmpaggknkjlbag" would be your FTB extension folder, go in and delete the 1.25.8 folder and you should be able to download and install mods to existing mod pack. One drawback, you will have to delete this folder every time you want to install a new mod. I have created a batch file that automatically deletes the folder then launches the FTB app.

Wow, this worked instantly for me, a bit of a clunky workaround but got my mods added in easily once it launched as 1.25.7