FTBTeam / FTB-App

Electron, Vue2, and Tailwind based frontend system for the FTB App; a new Modpack launcher for FTB and Curse modpacks.
https://feed-the-beast.com/app
GNU Lesser General Public License v2.1
86 stars 22 forks source link

Special Characters in PC usernames cause Java issues #1144

Open WyFryMU opened 3 weeks ago

WyFryMU commented 3 weeks ago

What Operating System

Windows 11

Debug Code

FTB-DBGERAWONUFOZ

Describe the bug

(That code is from efetarkgkc in the ftb discord) When a player has a special character in their name, the ftb app tries to access it's included java.exe which fails due to the special character.

Steps to reproduce

  1. Have a PC user with a special character in their name
  2. Boot up FTB App
  3. Try to launch a modpack
  4. Fail to launch modpack

Expected behaviour

Modpack launches

Screenshots

No response

Additional information

More examples from other people in the FTB Discord. (First one is taken from the above debug code)

Java.io.IOException: Cannot run program "C:\Users\Efe Tarýk Gökçe\AppData\Local\.ftba\bin\runtime\jdk-17.0.2+8-jre\bin\javaw.exe" (in directory "C:\Users\Efe Tarık Gökçe\AppData\Local\.ftba\bin"): CreateProcess error=2, Sistem belirtilen dosyayı bulamıyor

java.io.IOException: Cannot run program "C:\Users\Lu�s Leimig\AppData\Local\.ftba\bin\runtime\jdk-17.0.2+8-jre\bin\javaw.exe" (in directory "C:\Users\Luís Leimig\AppData\Local\.ftba\instances\ftb stoneblock 3"): CreateProcess error=2, O sistema não pode encontrar o arquivo especificado

java.io.IOException: Cannot run program "C:\Users\Jo�o\AppData\Local\.ftba\bin\runtime\jdk-17.0.4+8-jre\bin\javaw.exe" (in directory "C:\Users\João\AppData\Local\.ftba\bin"): CreateProcess error=2, O sistema não conseguiu localizar o ficheiro especificado

java.io.IOException: Cannot run program "C:\Users\Usu�rio\AppData\Local.ftba\bin\runtime\jdk-17.0.7+7-jre\bin\javaw.exe" CreateProcess error=2, The system cannot find the file specified

java.io.IOException: Cannot run program "C:\Users\Lukas Hoßfeld\AppData\Local\Overwolf\Extensions\cmogmmciplgmocnhikmphehmeecmpaggknkjlbag\1.25.10\launcher-3fd58fbe04-all.jar" (in directory "C:\Users\Lukas Hoßfeld\AppData\Local\.ftba\instances\ftb skies expert"): CreateProcess error=193, %1 ist keine zulässige Win32-Anwendung

java.io.IOException: Cannot run program "C:\Users\Basia i sp�ka\AppData\Local\.ftba\bin\runtime\jdk-17.0.2+8-jre\bin\javaw.exe" (in directory "C:\Users\Basia i spółka\AppData\Local\.ftba\instances\361c0652-779b-4a61-903f-edc74537aedc"): CreateProcess error=2, Nie można odnaleźć określonego pliku

WyFryMU commented 3 weeks ago

The workaround that I've been telling people is to install their own java versions then point the modpack at it. That will hit C:/Program Files instead of hitting their special character name.

WyFryMU commented 2 weeks ago

Another instance: https://pste.ch/cilusorave (shows in the 2nd debug log zip) This same player's installations.json: installations.json