FTBTeam / FTB-App

Electron, Vue2, and Tailwind based frontend system for the FTB App; a new Modpack launcher for FTB and Curse modpacks.
https://feed-the-beast.com/app
GNU Lesser General Public License v2.1
95 stars 26 forks source link

Mods listed multiple times when updated #1198

Open Scoboose opened 1 month ago

Scoboose commented 1 month ago

What Operating System

Windows 11

Debug Code

Failed to upload logs, please try again later

Describe the bug

When using a custom-made mod pack, updating a mod results in the mod being listed twice.

Steps to reproduce

  1. Create a new instance and add a mod
  2. Update mod

Expected behaviour

It only show the installed mod once

Screenshots

image

Additional information

It seems like modifications.json is not correctly being updated. If I manually remove the old versions from modifications.json the expected behavior is achieved

I am on app version 1.25.18

ftb-helper[bot] commented 1 month ago

Hay, thanks for the issue! Unfortunately it looks like you've not provided a Debug code... We require this as it helps us find your issue as quickly as possible.

Please do the following

Upload Logs using the app

Open the Settings page in the FTB App, then go to the app tab and click on the Upload Logs button, this might take a few seconds to complete. Once it's done, you will see a message saying that the code has been copied to your clipboard.

Either edit your original issue or add a comment with this code.

Using the FTB Debug tool

Only use this method if asked to or if your app wont open fully/the above method doesn't work, you can use the FTB Debug tool to generate a code for you.

Please use the link below to download and run the FTB Debug tool. This is a tool built by our App Developers and will provide you a code that you need to attach to this issue. Please either edit your original issue or add a comment with this code. If you need more help running this tool, you can follow our guide on how to use the FTB Debug tool.

Windows // MacOS // Linux // Windows (Arm) // MacOS (Arm) // Linux (Arm)

Scoboose commented 1 month ago

Debug code using the FTB Debug tool: dbg:NqSO_-LRA-c

MichaelHillcox commented 1 month ago

Which modpack is this?

Scoboose commented 1 month ago

Self made

MichaelHillcox commented 1 month ago

Ah, I see, I think this is a known issue but thanks for bringing it up. We have a minor duplication issue when installing mods that depend on other mods that in-turn depend on other mods. At the second level, it looks like it causes duplication to show up.

Hopefully I can ship an update some time soon

Scoboose commented 1 month ago

Awsome! Thanks for the reply. Hope you have a great day.