search

FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
42 stars 13 forks source link

[Bug]: Quartz Glass texture not showing correctly #1223

Closed flleeppyy closed 5 months ago

flleeppyy commented 2 years ago

Modpack

FTB Revelation

Modpack version

3.6.0

Log Files

No response

Describe the bug

Quartz Glass from Applied Energistics does not show up properly.

Steps to reproduce

I'm not exactly sure how to reproduce this, but we're trying to build a dome under water with the openblocks. Refer to screenshots.

Expected behaviour

Blocks texture should show as normal.

Screenshots

2022-08-06_00 02 18 2022-08-06_00 02 20 2022-08-06_00 02 23

Video https://0x0.la/u/JsnlnL1.mp4 (Ignore voice at the end, that's my friend)

Additional information

No response

TheonlyTazz commented 2 years ago

this issue is probably caused by optifine and the use of shaders. i cannot replicate this issue with the default setup of Revelations.

try again without optifine and report if the issue still happens

flleeppyy commented 2 years ago

Disabled optifine, issue still persists 2022-08-06_02 34 09 2022-08-06_02 34 12 2022-08-06_02 34 15 2022-08-06_02 34 42 2022-08-06_02 35 44

.

Raidobw2 commented 2 years ago

Hmm, thanks for trying it without Optifine. I can confirm I can reproduce this, however I'm unsure how we would be able to fix that at all. image It looks like https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/4114 was supposed to fix this, since it was reported for rv6-stable-7 on 1.12.2. However it looks like that commit https://github.com/AppliedEnergistics/Applied-Energistics-2/commit/2c0a2975de42db37d0e66eb81216f82215ca51dd made it into AE2 v9 on Fabric which I'm assuming is 1.19+, but was never backported to the original version this was reported on, in 1.12.2.

So normally the version after rv6-stable-7 would have had that bugfix, however I don't see it ever released: image

I've also tried without CTM (Connected textures) to see if that made any difference, it didn't.

AE2 1.12.2 is no longer supported, so this isn't fixable, in the main mod at least image

It does look like that commit from earlier however made it into AE2 Unofficial Extended Life in 1.12.2 https://www.curseforge.com/minecraft/mc-mods/ae2-extended-life https://github.com/PrototypeTrousers/Applied-Energistics-2/blob/9fdf0345b3f90429534626d1ebdc6aa922c8e9ed/src/main/java/appeng/decorative/solid/BlockQuartzGlass.java#L108

We would have to test it and weight if it's worth it to add it into a future version of Revelation instead, that is the only way I could see this issue being solved. I'll turn this into an enhancement to check when the time comes, however I can't guarantee this will make it in. We'll need to test it thoroughly.