FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
40 stars 12 forks source link

Updating to 1.4.0 world fails to load[Bug]: #152

Closed Spyder1369 closed 2 years ago

Spyder1369 commented 2 years ago

Modpack

Oceanblock

Modpack version

1.4.0

Log Files

https://paste.feed-the-beast.com/view/695ec96c

Describe the bug

Ticking block entity crash when loading world after update. The log has issues with farmers delight tomatoes.

Steps to reproduce

Unknown, trying to figure out the block that caused the issue at the moment.

Expected behaviour

World Should load

Screenshots

No response

Additional information

No response

ChiKuro010 commented 2 years ago

same issue https://paste.feed-the-beast.com/view/b21b0667

Spyder1369 commented 2 years ago

To perhaps add context I turned on the setting to remove erroring items and entities in the server config and it bricked every hydroponic bed and plant gatherer, as in deleted full inventories and whenever it "completes" an operation with the GUI open it closes the GUI so well and truely broken. Other Industrial Foregoing blocks seem fine, nothing else seems to be having issues. After breaking two of the plant gatherers it now gets stuck waiting for server every time the world is loaded

legitswitch commented 2 years ago

Same issue: https://hastebin.com/yebelimuye.rust

I removed a hydroponic bed mentioned in the crash but it seems like it's all of them at some players base. Might be all hydroponic beds on the server, but I'm not going to delete them one by one per crash. Just gonna revert to 1.3 for now.

Spyder1369 commented 2 years ago

Ok after some more testing, I downgraded farmers delight and rolled back to my latest back up and it appears to be working fine no issue

Raidobw2 commented 2 years ago

vectorwing/FarmersDelight#334

TL;DR: Farmer's Delight had a class reorganisation which seemed a little bit subtile. Normally "old" Tomato crops would be erased from the game with the update, but instead they simply crash with a Ticking Block Entity and NoClassDefFound. Sent the issue to the mod maker and waiting on feedback.


(EDITED)

Fix: For the FTB App or any other launcher.

FTB App: Click on OceanBlock > Click Settings at the left > Click Open Folder at the bottom.

>>>Open your saves folder and copy paste your world elsewhere to keep a backup just in case.<<<

Open the mods folder and delete FarmersDelight-1.16.5-0.5.0.jar. Access Farmer's Delight CurseForge page and files: https://www.curseforge.com/minecraft/mc-mods/farmers-delight/files Get the file for "Farmer's Delight 0.4.6 - 1.16.5". Place the FarmersDelight-1.16.5-0.4.6.jar in your mods folder. Load the game again.

Raidobw2 commented 2 years ago

Sunekaer technical info is in the issue on Farmer's Delight issue tracker if you want to read the "why this happened", although I don't think you could've foreseen this, definitely seems unintended in his mod transition.

Spyder1369 commented 2 years ago

be forewarned this didn't fix it for me, I had no hydroponic beds with tomatos, it still killed( they had deleted their inventories and stopped functioning) all my hydro and plant gatherers and eventually broke the server. in single player the only fix I found was downgrading farmers delight.

Raidobw2 commented 2 years ago

You got another crash after trying to remove the erroring tile entities? The mod Farmer's Delight reorganized its classes, so if there isn't anymore items/crops planted from the mod anywhere, you can normally safely update. IF Integration would need code adjustments, this is no longer true after looking at both mods code

Raidobw2 commented 2 years ago

@Sunekaer IF = Industrial Foregoing, FD = Farmer's Delight

Summary: FD had a class reorganization which would normally delete old crops correctly from the game. For X reason, development got harder on FD's side and some stuff didn't make it to the changelog (that's why you didn't see it). I'm assuming they had massive restructure in the code, stuff gets heavy sometimes that's fine, we thank them for their mod. IF has a plugin for Harvestable crops that uses Class 1. When FD restructured classes, Class 1 got changed for Class 2. Therefore, IF's integration no longer works, since it was never adapted to work with Class 2. That's the error part.

FD's Author is still trying to decide himself: Keep the new FD structure or rollback the class changes and postpone to 1.17. I told him I can report to IF since that seems like an easy fix (although other modpack makers gotta be careful when they update IF). I also told him to make an API since that seemed like a great idea.

The immediate solution and fix for the modpack is to rollback FD's version to 0.4.6.

If IF implements Class 2 instead of Class 1, we will be able to update both FD and IF at the same time in a later OceanBlock update. That's all for this issue.