search

FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
40 stars 12 forks source link

Compact Machines worldgen is extremely slow #3364

Closed ukmcplyr closed 1 year ago

ukmcplyr commented 1 year ago

Modpack

FTB Skies

Modpack version

1.1.0

Log Files

I don't think have helpful logs yet (see below) but I will attach links to them once the server's been up a while and exhibits lag seen.

One thing of note though in a log (here) from a run through of the reproduction steps is this:

[13May2023 20:58:30.880] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Stopping server
[...]
[13May2023 20:58:31.090] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[world]'/compactmachines:compact_world
[13May2023 21:00:52.677] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[world]'/ad_astra:mars

Note how long it takes for compactmachines:compact_world's chunks to be written to disk. Wouldn't expect this on hardware with 3 SSDs in RAID-0 dedicated to MC but maybe it's unrelated?

Describe the bug

[Apologies if this is related to #3334 or another open issue, please mark as dupe if so and I'll post there if needed.]

Compact machine worldgen can get extremely slow. The below snippet shows me teleporting in to 4 compact machines, at least one of which I'm 99% sure had already been through its worldgen phase, and all four times it took in excess of 40 seconds on average:

[19:03:25] [Worker-Main-2/WARN] [ModernFix/]: Mod ad_astra is shipping outdated structure files, which can cause worldgen lag; please report this to them.
[19:03:25] [Worker-Main-2/INFO] [ModernFix/]: Instantiating Mojang DFU
[19:03:25] [Worker-Main-2/INFO] [minecraft/DataFixers]: Building unoptimized datafixer
[19:03:28] [Worker-Main-3/WARN] [ModernFix/]: Mod skyvillages is shipping outdated structure files, which can cause worldgen lag; please report this to them.
[19:03:35] [Worker-Main-4/WARN] [ModernFix/]: Mod hexerei is shipping outdated structure files, which can cause worldgen lag; please report this to them.
[19:03:36] [spark-async-sampler-worker-thread/WARN] [spark/]: Timed out waiting for world statistics
[19:03:37] [Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Is the server overloaded? Running 12063ms or 241 ticks behind
[19:03:46] [Worker-Main-2/WARN] [minecraft/UniformHeight]: Empty height range: [6 above bottom--1 absolute]
[19:03:46] [Worker-Main-2/WARN] [minecraft/UniformHeight]: Empty height range: [6 above bottom--1 absolute]
[19:03:46] [Worker-Main-2/WARN] [minecraft/UniformHeight]: Empty height range: [6 above bottom--1 absolute]
[19:03:46] [Worker-Main-2/WARN] [minecraft/UniformHeight]: Empty height range: [6 above bottom--1 absolute]
[19:04:37] [Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Is the server overloaded? Running 45051ms or 901 ticks behind
[19:05:36] [spark-async-sampler-worker-thread/WARN] [spark/]: Timed out waiting for world statistics
[19:05:56] [Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Is the server overloaded? Running 32796ms or 655 ticks behind
[19:07:36] [spark-async-sampler-worker-thread/WARN] [spark/]: Timed out waiting for world statistics
[19:07:39] [Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Is the server overloaded? Running 43604ms or 872 ticks behind

If this isn't a known issue, I can try and narrow down where the fault lies. On an in-dev modpack I'm working on with ~400 mods (large chunk of which are in Skies) and comparable amount of KJS scripts, Compact Machines worldgen takes max 15 seconds, usually less, and teleporting back and forth is noticeably quicker, too, on the same hardware.

Steps to reproduce

This seems to be dependent on uptime or maybe (minecraft) server load as running through the below steps on a freshly-restarted server behaves normally.

On a server:

  1. Place four maximum size compact machines
  2. Teleport to one and let its worldgen run
  3. Go back to the overworld
  4. Restart server
  5. Enter, wait for worlgen to finish, then leave all four compact machines one by one
  6. Observe the amount of time it takes

Expected behaviour

Compact Machine worldgen/teleportation should be less laggy

Screenshots

No response

Additional information

Note: I've added two mods to the server: Comforts (to workaround #2924) and Entangled. Tested both with and without.

Saereth commented 1 year ago

this should be resolved in the upcomming 1.2.0 update