FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
40 stars 12 forks source link

Cannot add Astrodux and CfB NoFilter books to Akashic Tome #3654

Open Parker8283 opened 1 year ago

Parker8283 commented 1 year ago

Modpack

FTB Presents Direwolf20 1.19

Modpack version

1.12.0

Log Files

No response

Describe the bug

The Ad Astra book and the Cooking For Blockheads #NoFilter book cannot be added to the Akashic Tome. They should be added to the config file for Akashic Tome by default.

Steps to reproduce

  1. Acquire an Akashic Tome, an Astrodux, and the Cooking For Blockheads #NoFilter book.
  2. Attempt to craft the Akashic Tome with the Astrodux or the Cooking For Blockheads book.
  3. See that it don't work :)

Expected behaviour

The tome should allow the books to be added

Screenshots

2023-07-09_23 50 30 2023-07-09_23 50 59

Additional information

No response

Gaz492 commented 3 months ago

Could you please confirm if you are still experiencing this issue with the latest pack version? If you are, would you be able to upload new log files for us so we can take a further look?

github-actions[bot] commented 3 months ago

This issue has been marked as stale. Please reply to the issue or the issue will be automatically closed in 3 days.

Parker8283 commented 3 months ago

This is still an issue on pack version 1.13.1. The issue is that Ad Astra book's registry name is ad_astra:astrodux, and the Cooking for Blockheads #NoFilter book has a registry name of cookingforblockheads:no_filter_edition. Akashic Tome uses an allowlist system for items to be allowed to be crafted with the Tome, both for the full registry name, and a substring match of certain words (like "book" or "tome"). Since astrodux and no_filter_edition both don't match any of the substrings defined in the Akashic Tome config file, nor are the full registry names in the "Whitelisted Items" section of the config file, neither book can be added to the Tome. So the Akashic Tome config file should have the "Whitelisted Items" section updated to add both of these books. I have manually done this locally on my own pack and it fixes the issue.