search

FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
43 stars 13 forks source link

FTBQuests recipes follow Item and not the Icon #5682

Open klugemonkey opened 2 months ago

klugemonkey commented 2 months ago

Modpack

Other...

Is your suggestion related to a problem? Please describe.

When clicking on an icon for a quest, the recipe that is display is based on the item and not the icon. It probably should follow the recipe for the icon if not explicitly set otherwise though some unimplemented feature.

The concern is that when a users sees the icon representing an item, they expect that the recipe for that item will show up when they click on it.

If you have an icon that is different from the item defined to satisfy the task/quest in the chapter it may show something irrelevant to the completion of the task. (i.e. on FTB NeoTech 1.7.0, LV and Me quest12, it has:

        {
            dependencies: ["43EDF843EE3FE31E"]
            description: [
                "{ftbquests.chapter.lv_and_me.quest12.description1}"
                ""
                "{ftbquests.chapter.lv_and_me.quest12.description2}"
            ]
            icon: "modern_industrialization:steel_boiler"
            id: "74BC32AACDEE0B2E"
            rewards: [
                {
                    count: 16
                    id: "082862B1D956060A"
                    item: "forcecraft:golden_power_source"
                    type: "item"
                }
                {
                    count: 12
                    id: "38E951A1B118CB03"
                    item: "modern_industrialization:steel_ingot"
                    type: "item"
                }
            ]
            shape: "rsquare"
            size: 1.25d
            tasks: [{
                icon: { Count: 2, id: "modern_industrialization:steel_boiler" }
                id: "2F7A67A5B8C50648"
                item: {
                    Count: 1
                    id: "ftbfiltersystem:smart_filter"
                    tag: {
                        "ftbfiltersystem:filter": "or(and(item(modern_industrialization:steel_boiler)stack_size(>1))and(item(modern_industrialization:bronze_boiler)stack_size(>3)))"
                    }
                }
                title: "{ftbquests.chapter.lv_and_me.quest12.task.title1}"
                type: "item"
            }]
            x: -19.0d
            y: 1.0d
        }

When the user is expecting the icon that shows a Steel Boiler and clicks on it for a recipe, they get the Smart Filter recipe.

By default the id of the icon should be used for the recipe, unless there is some other reason to use the item, such as in the case you are just using the icon for a visual aesthetic.

Perhaps the best way is to change the format so another variable determines if icon or item is used for the recipe of the icon.

Mod suggestion

No response