FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
40 stars 11 forks source link

"Missing" recipes for Thaumcraft vis crystals #5684

Open Delfayne opened 1 month ago

Delfayne commented 1 month ago

Modpack

FTB Interactions Remastered

Modpack version

1.0.1

Has the pack been modified

No

Log Files

No response

Describe the bug

Pressing R for recipes on Aer/Terra/Aqua/Ignis/Ordo/Entropy crystals do not show GT machine recipes.

However the recipes are configured, if you check Usages of e.g. aer-infused dust. This is potentially because the NBT of the two items is in the wrong order.

Thaumcraft's vis crystals have the NBT keys key then amount, whereas the recipes have amount then key. This is confusing because FTBI 2.0 is consistent with the latter for both TC and the recipe. Or I might be going down the wrong path with thinking NBT is an issue.

Steps to reproduce

Pressing R for recipes on Aer/Terra/Aqua/Ignis/Ordo/Entropy crystals do not show GT machine recipes.

Expected behaviour

Recipes should display

Screenshots

image

Additional information

No response

ArtpokeBr commented 3 weeks ago

Yeah it seems to be a NBT Issue, trying to fix it.

ArtpokeBr commented 3 weeks ago

Yeah, tested some things but not sure how to fix this one, JEI seems to always register things in specific way.

Delfayne commented 3 weeks ago

I recommend changing all references to vis crystals in scripts to use the ones in _global.zs, and swapping the amount and key tags in _global.zs. Ensure every reference consistently uses these keys in a strict order.

You can see this issue clearly play out in other ways. e.g. if you search for Ignis crystal in JEI and U it, there's no recipe involving an Astral altar for the ritual diviner, say. However if you go ignis dust then U, it shows the ignis crystal with a different NBT ordering THEN U that, you get to the diviner recipe.