search

FTBTeam / FTB-Modpack-Issues

Any and all FTB Modpack issues are here! Please create a new issue, add to an existing one or maybe even suggest a feature in the discussions
https://feed-the-beast.com/modpack
43 stars 13 forks source link

Xycraft grains of Infinity recipe not working #5843

Open NotPiffany opened 1 month ago

NotPiffany commented 1 month ago

Modpack

FTB Presents Direwolf20 1.21

Modpack version

1.2.1

Launcher

FTB App

Has the pack been modified

No

Log Files

No response

Describe the bug

The grains of infinity recipe for the Xycraft extractor isn't working. I tried setting it up with the extractor pointing both up and down in case the JEI diagram was upside down, but no luck.

Steps to reproduce

  1. Place down a reinforced obsidian block.
  2. Place down four cobbled deepslate blocks N,S,E,W of the reinforced obsidian.
  3. Place an extractor on top of the reinforced obsidian.
  4. Place an inventory on top of the extractor

Expected behaviour

The extractor should start working and place grains of infinity inside the inventory.

Screenshots

No response

Additional information

No response

Soaryn commented 1 month ago

Requires Fire below the target block. Admittedly, that was supposed to be a Forgecraft only recipe.

This is wrong appearing due to Fire not having a backing item anymore unlike older minecraft versions. So it needs some form of fire block (likely just normal fire)

NotPiffany commented 1 month ago

A campfire does not work, but netherrack set on fire does. Thanks, Soaryn.

Soaryn commented 1 month ago

Ohhh campfire is a good idea to add though!

becky15675 commented 1 month ago

Thank you Soaryn, this frustrated me a lot and had given up on it until I stumbled upon this. I got it working once I put the fire under the reinforced obsidian and yes, I too would like to use a campfire instead of flames

1John5vs7 commented 1 month ago

Thanks @Soaryn for the explanation. Just in case anyone is confused by the language when Soaryn says "target block", that means the block immediately under the Extractor.

I did:

Top layer: Extractor Middle layer: Reinforced Obsidian with Cobbled Deepslate North, South, East, and West of it Next layer: fire Bottom layer: netherrack

Just light the netherrack on fire and slap the reinforced obsidian down 1 block above the fire and your extractor should now get you 1 grain of infinity per 10 seconds!

mostlygizzards commented 1 month ago

Confirmed fix here

image image

Soaryn commented 1 month ago

Not exactly a bug in how the extractor operates, just the fact that there is no item for fire 😅

All of this is to be redone in the future, just dont have a timeframe on that yet.

1John5vs7 commented 1 month ago

Feels like the more important thing is to clarify the orientation of exterior vs source block in the GUI.

On Wed, Oct 9, 2024, 4:14 AM Soaryn @.***> wrote:

Not exactly a bug in how the extractor operates, just the fact that there is no item for fire 😅

All of this is to be redone in the future, just dont have a timeframe on that yet.

— Reply to this email directly, view it on GitHub https://github.com/FTBTeam/FTB-Modpack-Issues/issues/5843#issuecomment-2401647636, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVIJSEI2RGOOPK2FIKHBKTZ2TQWXAVCNFSM6AAAAABO5S6ZIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGY2DONRTGY . You are receiving this because you commented.Message ID: @.***>

1John5vs7 commented 1 month ago

Extractor*

On Wed, Oct 9, 2024, 6:51 AM D.W. Stratton @.***> wrote:

Feels like the more important thing is to clarify the orientation of exterior vs source block in the GUI.

On Wed, Oct 9, 2024, 4:14 AM Soaryn @.***> wrote:

Not exactly a bug in how the extractor operates, just the fact that there is no item for fire 😅

All of this is to be redone in the future, just dont have a timeframe on that yet.

— Reply to this email directly, view it on GitHub https://github.com/FTBTeam/FTB-Modpack-Issues/issues/5843#issuecomment-2401647636, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVIJSEI2RGOOPK2FIKHBKTZ2TQWXAVCNFSM6AAAAABO5S6ZIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGY2DONRTGY . You are receiving this because you commented.Message ID: @.***>

IamStig commented 1 month ago

Thanks zperk13 I will shut down #5919 now. I was thinking....does Xycraft have a lava block like the water block? (I don't have MC open atm) if it does, or one might be added, could that be used for these builds? in place of lava ...and fire maybe. it would be able to be used in the diagrams too. And would allow for far tidier builds. Maybe if @Soaryn Soaryn is getting notifications he might have a thought on this.

Raidobw2 commented 5 days ago

It seems this could potentially be fixed in the modpack by overriding the original fire recipe with a fix and adding a new recipe with the campfire.

kubejs/data/xycraft_machines/recipe/extractor/enderio/grains_of_infinity.json

kubejs/data/xycraft_machines/recipe/extractor/enderio/grains_of_infinity.json ```json { "type": "xycraft_machines:extractor", "adjacent": [ { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" }, { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" }, { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" }, { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" } ], "catalyst": { "block": "minecraft:fire", "predicate_type": "xycraft_core:block_rule" }, "output": { "Count": 1, "id": "enderio:grains_of_infinity" }, "target": { "block": "enderio:reinforced_obsidian_block", "predicate_type": "xycraft_core:block_rule" }, "ticks": 200, "hidden": true, "valid_directions": [ "down" ] } ```

kubejs/data/xycraft_machines/recipe/extractor/enderio/grains_of_infinity_campfire.json

kubejs/data/xycraft_machines/recipe/extractor/enderio/grains_of_infinity_campfire.json ```json { "type": "xycraft_machines:extractor", "adjacent": [ { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" }, { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" }, { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" }, { "block": "minecraft:cobbled_deepslate", "predicate_type": "xycraft_core:block_rule" } ], "catalyst": { "block": "minecraft:campfire", "predicate_type": "xycraft_core:block_rule" }, "output": { "Count": 1, "id": "enderio:grains_of_infinity" }, "target": { "block": "enderio:reinforced_obsidian_block", "predicate_type": "xycraft_core:block_rule" }, "ticks": 200, "valid_directions": [ "down" ] } ```

Fortunately there is a neat "hidden" property on the recipe serializer, which will hide the fire recipe from JEI. Both recipes would still be usable, but only the campfire one would show a visual in JEI, so this would be a non-breaking change for old setups using fire.

image