search

FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
19 stars 1 forks source link

[Bug]: Datapack function (mcfunction) #1165

Closed KevzCz closed 2 months ago

KevzCz commented 2 months ago

Mod

FTB Quests

Mod version

ftb-quests-fabric-2001.4.2 (older version still has the same issue)

Forge / Fabric version

1.20.1 (Fabric Modloader 0.15.10)

Modpack & version

No response

What issue are you having?

This is the logs. Functions that have ftbquests change_progress @p complete/reset ____ always seem to fail to load ONLY ON THE FIRST LOADING INTO THE WORLD after that FUNCTIONS LOAD FINE (AFTER EXITING THE GAME AND LOADING INTO THE WORLD AGAIN, THE PROBLEM CONTINUES AND ONLY FIXES WHEN YOU RELOG). I can't really release an update since its a huge hassle to log out and login, servers might have to reload, etc (haven't tested on servers) image image image image image image image image image image image image

Crashlogs

Didn't crash https://pste.ch/icapohiqiv.md

Steps to reproduce

  1. Make functions contains ftbquests change_progress comands
  2. Load into the world for the first time Fix:
  3. Log out after loading in

Anything else to note?

FTBQuests, FTBLibrary are on the latest version.

desht commented 2 months ago

It might be helpful if you actually showed your .mcfunction file(s)...

What's most likely happening here is (and the Minecraft Wiki confirms this) is that the very first function tick runs before the world is loaded and the server is properly started. So, you cannot use any /ftbquests command from a function tick, because the quest book is not yet available.

KevzCz commented 2 months ago

28C477BE-2698-4477-A4BB-30C1B28C3A44 I did show the .mcfunction files. I see that explains it a lot. Though i did think of making a system that auto reloads if a function fails to load up. Should i close this issue now?

desht commented 2 months ago

Yeah, I don't think there's much else that can be done here. Tick functions just won't work on the very first tick for FTB Quests commands.