search

FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
18 stars 1 forks source link

[Bug]: FTB Quest link creation to other chapters has a bug in its formatting by defailt #1202

Open Saereth opened 1 month ago

Saereth commented 1 month ago

Mod

FTB Quests

Mod version

ftb-quests-neoforge-2004.2.0

Forge / Fabric version

20.4.234

Modpack & version

FTB InDevelopment pack

What issue are you having?

When making a link to another chapter with the ingame ui it formats it as such:

[ "Head over to the ", { "text": "Wheels of Fortune Chapter", "underlined": "true", "clickEvent": { "action": "change_page", "value": "595F1E9BDF4FB832" } }, " to setup your first tree farm using Steve's Carts 2!" ] The underlined value however should be an integer 1 or 0 instead of a string so it errors.

image

Changing it to a 1 instead of "true" fixes the issue

image

Crashlogs

No response

Steps to reproduce

Make a quest with a link to another quest

Anything else to note?

No response

desht commented 1 month ago

Yeah I noticed that with the 1.20.6 port yesterday and fixed it there; can backport that to 1.20.4, I guess.

Mojang's JSON parsing engine has obviously changed in 1.20.4+ and is stricter now, it appears. Booleans should be an unquoted true or 1 now, not "true" which worked OK in 1.20.1.