FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
22 stars 1 forks source link

[Bug]: Item Filters do not work if there is more than one tag or item #1359

Open valkyrienyanko opened 1 week ago

valkyrienyanko commented 1 week ago

Mod

FTB XMod Compat

Mod version

ftb-xmod-compat-fabric-2.1.1

Forge / Fabric version

Fabric 1.16.5

Modpack & version

The Energy Race v18.7

What issue are you having?

If more than one item or tag is added to a filter it will not work correctly in quests. (If the filter contains only one tag or item then the filter will work.

I was originally going to use the tag morehammersexcavators:hammers except I've found that the tag does not include all the hammer items so this will not work for me, I will need to add all the items to the filter manually.

Creating the filter

Untitled

What the filter looks like in quests

Untitled

Clicking on the filter in quests

Untitled

What I was expecting to see

I was expecting to see something like this (please ignore the fact that these are excavators and not hammers) Untitled

Crashlogs

No response

Steps to reproduce

  1. Search for "Smart Filter" in creative mode
  2. Add at least 2 things to the filter
  3. Add this filter to a quest
  4. Notice how it does not display the items
  5. Modify the filter to only include one thing
  6. Notice how the filter in the quest works now

Anything else to note?

This is for Minecraft 1.20.1.

WyFryMU commented 1 week ago

Yeah I get the same issue even when using only the ftb mods and necessary dependencies. image image image

Modlist: image

desht commented 4 days ago

The top-level filter is an "All of", which requires all the conditions under it to be true. Try placing an "Any of" compound filter under the top-level, and putting your filter inside that (note: the GUI allows drag & drop, so you can add the Any of filter, and drag your tags into it).