search

FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
21 stars 1 forks source link

[Bug]: Quests are ignoring NBT data #182

Open Elrol opened 2 years ago

Elrol commented 2 years ago

Mod

FTB Quests

Mod version

ftb-quests-forge-1801.3.7-build.91

Forge / Fabric version

1.18.1-39.0.59

Modpack & version

No response

What issue are you having?

I am working on creating quests for my pack and I set the NBT data for the quest tasks. However, as soon as I get an item in my inventory that is the same base item without the NBT data, it still completes the quest.

I have various quests for collecting statues that have a custom name and lore. But the quest ignores the NBT and completes any time you have any player statue in your inventory.

Crashlogs

No response

Steps to reproduce

Create a quest with a task that has specific NBT data Put the item in your inventory without the NBT data Quest will complete regardless of NBT data

Anything else to note?

No response

Raidobw2 commented 2 years ago

This affects 1.16.5 as well https://github.com/FTBTeam/FTB-Mods-Issues/issues/300

desht commented 1 year ago

FTB Quests now uses the Item Filters mod (a mandatory dependency) to handle item matching for item tasks. By default, Item Filters doesn't try to match itemstack NBT unless the item is in the itemfilters:match_nbt item tag. While this is technically intended behaviour, I will admit that it's not well documented or intuitive.

An easy short-term workaround is simply to add your statue item (or any item which needs NBT matching) to that item tag. I am considering a longer-term solution now, possibly a "Check NBT" tri-state config for item tasks:

Might also be nice to have a "Weak NBT check" boolean: