search

FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
22 stars 1 forks source link

[Feature Request]: FTB Quests (Fabric) Compatibility with EMI #312

Open sisby-folk opened 2 years ago

sisby-folk commented 2 years ago

Mod

FTB Quests

Description

EMI is a reimagining of an in-game recipe book / item index. While FTB Quests has support for REI on fabric, whatever it hooks into doesn't apply for EMI.

From latvian.dev: image image

Describe the solution you'd like

I've confirmed with Emi that the API for EMI is stable.

The only integration i'm really concerned about is being able to click on an item required in tasks to see its recipe, which I imagine won't change.

EmiAPI::displayRecipes()

Describe alternatives you've considered

No response

sisby-folk commented 1 year ago

Freshened up the description a bit and fixed the link. Still should just be a single method call ideally.

unilock commented 1 year ago

I've made a fork of "FTB XMod Compat" with extremely preliminary EMI support here:
https://github.com/unilock/FTB-XMod-Compat/tree/1.19/dev-emi

All that's done so far is clicking items in the quest book to view their recipes. But it works! (indeed, it was only a single method call, heh)

sisby-folk commented 1 year ago

Appreciate the work there - the license on that mod compat doesn't look any less strict than FTB quests itself though, and there's never been an external PR to it before - are you going to spin up a draft PR while you work? I assume this has to go the whole process of being bumped in FTB quests itself as a JIJ.

desht commented 1 year ago

(FTB Quests dev here)

This looks like a great start, and we'd be prepared to merge a PR with EMI support, although if you can figure out how to represent quest rewards and loot crates as "recipes" in EMI (as the existing JEI and REI support does), that would be ideal.

sarpuser commented 2 months ago

I recently came across this issue as I was playing Prominence 2 RPG. Has there been any updates on this? Is this still something that is actively being worked on? @unilock do you have a working version for 1.20?

SanQianQVQ commented 2 months ago

I'm not sure if the problem has been solved, because I still encounter this problem emi-1.1.12+1.20.1+fabric ftb-quests-fabric-2001.4.8 ftb-xmod-compat-fabric-2.1.1 Frustrating