FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
23 stars 1 forks source link

[Feature Request]: Extend vanilla Teams functionality #631

Open UselessRobot opened 1 year ago

UselessRobot commented 1 year ago

Mod

FTB Teams

Description

an FTB Teams team could be synchronised with a vanilla scoreboard team optionally. This could allow non player entities to be in an FTB Teams team, run commands that can affect a whole FTB Teams team and also adopt some of the already implemented functionality from scoreboard team rules like collision or damage.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

desht commented 1 year ago

Interesting idea. I guess at its simplest, this would just be a boolean "Add Vanilla Team" setting in the FTB Teams properties?

If that were enabled, a scoreboard team would be auto-created (/team add <team-id> <team-name>) where team-id would be the FTB Team UUID, and team-name would be the FTB Team display name.

Any players in the FTB team (this should probably only work for party teams) would be auto-added (/team join <team-id> <player-uuid>). Players leaving the FTB team would be auto-removed from the scoreboard team (/team leave <team-id> <player-uuid>)

If the property were disabled or the FTB team disbanded, the scoreboard team would be auto-removed (/team remove <team-id>)

Setting the scoreboard team properties could be a little problematic, since the /team command requires permission level 2, which an FTB team owner does not necessarily have. This could be done by proxying it through FTB Teams, effectively allowing the command to be run with elevated permission, but only for the FTB team owner's (or officer's?) associated scoreboard team. Some thought should be given to which scoreboard teams properties can be modified in this way.

Is all this how you envisaged the integration working?

UselessRobot commented 1 year ago

I didn't actually know about the /team permission levels but if that's could be easily solves as you mentioned I don't see any immediate issues with it other than that. It might be worth allowing some vanilla teams properties to be allowed to be configurable through a server config file, that way a server admin will ultimately have the final say but a FTB teams owner can change whatever properties they are allowed to, reducing the chances of teams properties abuse. I won't say that this would be a simple addition, but I'm willing to bet this wouldn't negatively affect the rest of the mod, at least with any immediate side effects.

iSoulEs commented 4 months ago

is this still alive? It would really be a great feature. I am using hybrids and without the mentioned function the plugins do not detect the party.