search

FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
21 stars 1 forks source link

[Bug]: Custom Icon Item crashes the client when trying to select icon #725

Open coaber opened 1 year ago

coaber commented 1 year ago

Mod

FTB Quests

Mod version

ftb-quests-forge-1802.3.14-build.191

Forge / Fabric version

Forge 1.18.2/40.2.0

Modpack & version

Custom

What issue are you having?

Both when using the quest menu to select any custom icon, or if using the custom icon item will cause the client to freeze then crash. The first thing to point out is that CnB has a sussy texture name which causes ftb quests to freak out totally, but i may be wrong. crash report below

Crashlogs

crash-2023-03-26_15.10.48-client.txt

Steps to reproduce

Anything else to note?

more info can be provided if requested

desht commented 1 year ago

That resource location in the crash log (chiselsandbits:textures/CnB-CF-Thumbnail.png.mcmeta) is most definitely invalid, but I can't reproduce your crash. Please provide clearer instructions on reproducing the problem.

coaber commented 1 year ago

That resource location in the crash log (chiselsandbits:textures/CnB-CF-Thumbnail.png.mcmeta) is most definitely invalid, but I can't reproduce your crash. Please provide clearer instructions on reproducing the problem.

I ended up finding a temporary fix by disabling Chisel and Bits. I can't really provide a better walkthrough, because I don't actually know what can trigger it, i do know the texture mentioned in the log is the mod's icon, so the only thing i think triggered it is the name using special characters and uppercase letters

desht commented 1 year ago

I will add a workaround in FTB Library to ensure invalid resource locations never get used in icons, but it would be good to know how these are creeping in in the first place...