FTBTeam / FTB-Mods-Issues

Any mod issues, be it FTB Teams, Quests or any other of our mods can be reported here!
23 stars 1 forks source link

[Bug]: Server Crash WarmupCooldownTeleporter #865

Closed aws0jam closed 1 year ago

aws0jam commented 1 year ago

Mod

FTB Essentials

Mod version

ftb-chunks-forge-1902.3.22

Forge / Fabric version

forge-1.19.2-43.2.14-

Modpack & version

No response

What issue are you having?

I don't know for sure, but I think that something happens during teleportation and the server crashes

Crashlogs

https://pste.ch/ibidenaquf.rb

Steps to reproduce

Perhaps the players teleport from twilight to the overworld

Anything else to note?

No response

desht commented 1 year ago

ftb-essentials-forge-1902.3.3-build.9999.jar

Why are you running a dev build here?

aws0jam commented 1 year ago

Because of luckperm support.

desht commented 1 year ago

FTB Essentials 1902.3.3 as published on CurseForge includes luckperms support, so please use that. If you're still seeing the problem then, I'll take a look.

While you're welcome to build and use dev builds, please do not raise issues against them. If you're building and running your own dev build, you're expected to be able to debug issues yourself.

aws0jam commented 1 year ago

https://pste.ch/sucoqucuxe.coffeescript get same arror with non dev build

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it is in a state of "Awaiting Reply" but no reply has been received within 14 days. It will be closed within 7 days if it is not updated with a reply.

desht commented 1 year ago

This one might be hard to track down, since I can't reproduce it, and I can't see what in the code would cause a CME. CME's can generally open happen if there's multithreaded access going on (there isn't here), or if something modifies the hashmap during iteration (again, not happening).

I've made an experimental change which isolate all modifications to the hashmap to the tick method, which you can try out - get it from https://maven.saps.dev/releases/dev/ftb/mods/ftb-essentials-forge/1902.3.4-build.101/ftb-essentials-forge-1902.3.4-build.101.jar

Can't guarantee it'll help, but even if not it might provide some more clues as to what's happening.

desht commented 1 year ago

Just checking if you've had a chance to try that dev build?

oozeyyy commented 1 year ago

I can reproduce this on my TNP LL7 server consistently, on v18 it crashes whenever a player teleports from another dimension (nether) into another (overworld) with warmup enabled.

We primarily use /home to get back from the nether but /tpa and /back also cause the same issue. It seems to happen 1/10 times when a single player is teleporting but it happens 100% of the time when multiple players are teleporting and one of those players is tp'ing from one dimension to another.

Mod ver - ftb-essentials-forge-2001.1.2.jar MC ver - 1.20.1 Forge - 47.1.3

Crashlog -

crash-2023-08-20_18.55.20-server.txt

https://pastebin.com/ivbaN6Td

desht commented 1 year ago

@oozeyyy have you tried that dev build?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it is in a state of "Awaiting Reply" but no reply has been received within 14 days. It will be closed within 7 days if it is not updated with a reply.

stale[bot] commented 1 year ago

This issue has been automatically closed because due to lack of response.