FTXInfotech / laravel-adminpanel

A Laravel Admin Panel (Laravel Version : 6.0)
966 stars 461 forks source link

Demo link not working #349

Closed bvipul closed 5 years ago

vrkansagara commented 5 years ago

Hello @bvipul This issue arise because of module generator , if you crate any random module using white space so it break laravel basic flow for web routing and controller and migration as well so we need to really take care of it while we give an UI for such operation !

vrkansagara commented 5 years ago

Also I found another issue for this message "Note : You need to have 0777 permission to all folders of the project." As this is not a security best practise from server side.

bvipul commented 5 years ago

Yes we need to take care of this issue.

But for the permission note, it doesn't matter if the permission is required to be 777, as modules are supposed to be created only in development environment, and then make changes and then deploy to your server. So, the permission one is not an issue.

bvipul commented 5 years ago

Although the space in name needs to be rectified, by camel case name or something like that. Suggestions are appreciated.

vrkansagara commented 5 years ago

@bvipul I am facing this issue of demo link because once space is inserted by module creator it break the application flow as per expected result so , We are getting multiple open issue for demo link.

bvipul commented 5 years ago

Okay, I will look into the package for the issue. Will release a version soon

vedbhawsar commented 5 years ago

@bvipul there is one more issue I noticed in module generator. When it creates the module, in view file the reference object is in singular but from the EditResponse.php file its pass as the plural name.

from EditResponse.php:

   return view('backend.tests.edit')->with([
        'tests' => $this->tests
    ]);

in edit.blade.php:

    Form::model($test, ['route' => ....

This gives an error when implementing edit view for a module.

viralsolani commented 5 years ago

@vrkansagara Take the latest pull of master branch in the demo. it will fix the issue now.

peterquentin commented 5 years ago

Demo (the one from README.md) is broken again.

vrkansagara commented 5 years ago

I will it and let you know.

On Mon, 17 Jun, 2019, 10:12 PM Peter Quentin, notifications@github.com wrote:

Demo https://laravel-adminpanel.vrkansagara.in/ (the one from README.md) is broken again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/viralsolani/laravel-adminpanel/issues/349?email_source=notifications&email_token=AC3TIU6IMJEX3CZJKK3PCK3P265G7A5CNFSM4GXNU5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3YL5I#issuecomment-502760949, or mute the thread https://github.com/notifications/unsubscribe-auth/AC3TIU6WX7TWKAQERG5VGHDP265G7ANCNFSM4GXNU5PA .

noahheck commented 4 years ago

I don't know if this got fixed, but it (the demo link from the main README) is not working at this time.

vrkansagara commented 4 years ago

@noahheck and @peterquentin , Link is working. Please check.

noahheck commented 4 years ago

@vrkansagara The link is working now. Thanks!