FUB-HCC / IKON-projektor

Frontend component for https://github.com/FUB-HCC/IKON-backend
https://fub-hcc.github.io/IKON/
GNU Affero General Public License v3.0
5 stars 2 forks source link

Integrate Browser-/Touch-Version #194

Closed jessebenjamin closed 4 years ago

jessebenjamin commented 4 years ago

The goal is that both versions are hosted at the MfN.

mx-e commented 4 years ago

there is no way to reliably distinguish between displays with/without touch support in browser for multiple browsers / platforms

the standard approach would be to implement handlers for both event types. however, we serve a completely different app (layout, components) to the touch displays you would not for example want to display the touchscreen version of the app on a Surface Tablet, just because it supports touch, even if the distinction could be made.

one could use a /touch url extension to manually switch between versions this would however be publicly usable

mx-e commented 4 years ago

how do we go ahead ?

wittenator commented 4 years ago

In my opinion it is not too bad, that it is publicly available. The only question is whether we implement the router split logic in react or in Nginx

mx-e commented 4 years ago

to implement it in react would result in a more maintainable code base. However, depending on how much legacy code would need to be improved to handle the level of flexibility required, it might not be worth the effort. I'll get back to you on this, after taking a look at the current diff (few days, few other tickets ahead)

For now do @jessebenjamin @ckinkeldey agree on using a url extension as a flag ?

wittenator commented 4 years ago

Agree on the maintainability 👍

jessebenjamin commented 4 years ago

yes url-extension