search

FUMR / tidal-async

Python Tidal streaming service unofficial API in async fashion supporting OAuth2 authentication
GNU Lesser General Public License v2.1
21 stars 4 forks source link

Add linting on pre-commit #27

Closed wvffle closed 4 years ago

wvffle commented 4 years ago

Add linting

JuniorJPDJ commented 4 years ago

BTW. Is there any linter check for compatibility of signatures with base classes?

     async def tracks(self) -> List[Track]:

If possible please add this :3 Should fails this test, as tracks in generic.TrackCollection returns AsyncGenerator.

wvffle commented 4 years ago

~I guess that mypy is dealing with that. At least it should~ Nope, mypy does not handle that

wvffle commented 4 years ago

I've also just found this great article about python formatters: https://www.kevinpeters.net/auto-formatters-for-python

And I need to say that I'd stay with black, as this branch is.

JuniorJPDJ commented 4 years ago

~I guess that mypy is dealing with that. At least it should~ Nope, mypy does not handle that

Do you know anything that would?

wvffle commented 4 years ago

~I guess that mypy is dealing with that. At least it should~ Nope, mypy does not handle that

Do you know anything that would?

No