search

FUMR / tidal-async

Python Tidal streaming service unofficial API in async fashion supporting OAuth2 authentication
GNU Lesser General Public License v2.1
21 stars 4 forks source link

Update music-service-async-interface #38

Closed JuniorJPDJ closed 4 years ago

JuniorJPDJ commented 4 years ago

Nvm

wvffle commented 4 years ago

Can't we specify it by the version?

JuniorJPDJ commented 4 years ago

@wvffle No, we will do versions when it will be at least partially stabilized :v

wvffle commented 4 years ago

are python modules following semver? Then we can do 1.0.0-alpha.3

wvffle commented 4 years ago

And of course not publish the package.

Or actually publish as it's alpha

JuniorJPDJ commented 4 years ago

@wvffle they do, but imo for this level of alpha 0.X.X is much better

wvffle commented 4 years ago

s/does/do/

Then I opt to use 0.0.1-alpha.1

JuniorJPDJ commented 4 years ago

The worst part about versioning it in this state is that we will need to grow version in both projects 23589423598 times a week. Both would need new pull requests. For this moment I'd totally stay with commit hash.

wvffle commented 4 years ago

That's where semver resolves this problem. If poetry is implementing it correctly then we can add ^0.0.1-alpha to dependencies and when we'll bump the alpha number, it should install the newest one

wvffle commented 4 years ago

I mean, we bump version in generic repo and then when we run poetry install in this repo, it should always use newest alpha

JuniorJPDJ commented 4 years ago

@wvffle So we could just dump specifing commit version and it would be the same atm and we already had conversation about specifing dep version so it keep working

JuniorJPDJ commented 4 years ago

@JuniorJPDJ eg. today changes would totally break old versions if commit hash wasnt specified

JuniorJPDJ commented 4 years ago

@JuniorJPDJ semver is cool if api already stabilized at least a bit but it still didnt

wvffle commented 4 years ago

@JuniorJPDJ eg. today changes would totally break old versions if commit hash wasnt specified

That's why we're still in alpha. Don't expect that software in alpha stage will be backwards compatible

JuniorJPDJ commented 4 years ago

@wvffle And we already use semver, look at version definition in pyproject file

wvffle commented 4 years ago

A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version.

Taken from semver.org