search

FUMR / tidal-async

Python Tidal streaming service unofficial API in async fashion supporting OAuth2 authentication
GNU Lesser General Public License v2.1
21 stars 4 forks source link

Search implementation #74

Closed JuniorJPDJ closed 3 years ago

JuniorJPDJ commented 3 years ago

I need some feedback guys ;)

ATM It depends on commit from draft PR, will be changed later.

depends on FUMR/music-service-async-interface#31 resolves #30

JuniorJPDJ commented 3 years ago

The search implementation itself is very identical to the 0.7.x version of tamland/python-tidal, LGTM.

It's totally other than python-tidal, which is closer to how API itself works. I wanted to do this in generic way so we can use search in similar ways for every other service. The difference is in a way it returns values.

Anyway - thanks for positive feedback @divadsn :D

I also fixed things @wvffle found, thanks for your review guys ;)

JuniorJPDJ commented 3 years ago

I just changed dep commit to point on merged FUMR/music-service-async-interface#31. I think it's ready to go. I'm now playing with tests and CI on #76 so I'll fix that caching bug there - tests will not pass on this PR.