search

FUMR / tidal-async

Python Tidal streaming service unofficial API in async fashion supporting OAuth2 authentication
GNU Lesser General Public License v2.1
21 stars 4 forks source link

Return DASH manifest as data URI #77

Closed TpmKranz closed 2 years ago

TpmKranz commented 2 years ago

This is a workaround for cases when the manifest is not a JSON object but a b64-encoded DASH manifest. The data scheme allows to keep the interface of get_file_url unchanged. Clients that can't deal with data URIs would've choked on the JSONDecodeError anyway and those that do will just consume them like URLs. Tested with ffmpeg/ffplay and Clementine, both of which don't mind playing data URIs. MPV, for example, doesn't like them.

Linting failed due to files unchanged by me, so I had to turn it off. Sorry about that.

JuniorJPDJ commented 2 years ago

Linting failed due to files unchanged by me, so I had to turn it off. Sorry about that.

Thanks, good to know. I'll take care about it in a moment.

JuniorJPDJ commented 2 years ago

@TpmKranz could you rebase on top of master? linter and test errors should be fixed now

JuniorJPDJ commented 2 years ago

Also would be cool if you could reword commit message to conform with conventional commits. Our git log is good example of how it should look like.

If you can't do it I can, just say ;)