search

FWGS / hlsdk-portable

Portable Half-Life SDK. GoldSource and Xash3D. Crossplatform.
https://xash.su
Other
272 stars 125 forks source link

Elevator bug in Blue Shift #330

Closed FreeSlave closed 2 years ago

FreeSlave commented 2 years ago

Running the ba_elevator map converted by BlueShiftBSPConverter on GoldSource. After player presses a button the elevator is getting stuck and damages player and a scientist. Happens on both master and bshift branches.

nekonomicon commented 2 years ago

May be related: https://github.com/FWGS/hlsdk-portable/commit/c041db99097241996d802fef42e5d4f28e549246

FreeSlave commented 2 years ago

Yes, deleting these lines fixes the bug. Why it was introduced in the first place? Why 0.05 is chosen as a number to compare to? Modifying it to 0.02 also fixes the problem.

nekonomicon commented 2 years ago

It was backported from Half-Life: Gravgun to prevent some bugs with elevators, but may be incorrect.

FreeSlave commented 2 years ago

Should we revert it completely? Maybe it should be left only for multiplayer or only for Xash3D? If there's a reproducible case where LinearMoveDone is not getting called without these lines, we should somehow make it work in both cases.

nekonomicon commented 2 years ago

Maybe it should be left only for multiplayer or only for Xash3D?

This fix for coop mode.

nekonomicon commented 2 years ago

Related fix in gravgun branch: https://github.com/FWGS/hlsdk-portable/commit/7999455e9f9b73fb8c739b2cf864386a7f3466fe

FreeSlave commented 2 years ago

Then maybe it should have kept in gravgun branch, but not others.

FreeSlave commented 2 years ago

Fixed in https://github.com/FWGS/hlsdk-portable/pull/331 Closing