search

FWGS / hlsdk-portable

Portable Half-Life SDK. GoldSource and Xash3D. Crossplatform.
https://xash.su
Other
266 stars 121 forks source link

Latest commit breaks library naming scheme for CMake #411

Closed a1batross closed 8 months ago

a1batross commented 8 months ago

https://github.com/FWGS/hlsdk-portable/commit/b89ce4c52703fc5b9e13683ecd1919b98694a9a2

This breaks library naming scheme. I suppose because LibraryNaming is getting called BEFORE it has been decided to append -m32 on 64-bit compilers, thus adding _amd64 on 32-bit targets. Toggling 64BIT option doesn't help at all.

It also weirdly interacts with CMake cache, I just had a build without _amd64 suffix, presuming it's built for 32-bit, but it actually was 64-bit binary.

a1batross commented 8 months ago

I suggest reverting this commit and instead sanity checking the compiler if XASH_AMD64 was enabled if user selected 64BIT build type, or XASH_X86 otherwise.

a1batross commented 8 months ago

Seems to be reverted. Thanks.