search

FWGS / hlsdk-portable

Portable Half-Life SDK. GoldSource and Xash3D. Crossplatform.
https://xash.su
Other
266 stars 121 forks source link

Port func_vehicle implementation from cs16-client/regamedll_cs. #428

Closed nekonomicon closed 7 months ago

a1batross commented 7 months ago

Yeah, they don't have anything on this file...

Message ID: @.***>

FreeSlave commented 7 months ago

I tried the branch with this map https://twhl.info/vault/view/6815 I can't turn the vehicle for some reason, only move forward (I can turn when I run the map in HL) Also the sound doesn't stop after I stop the vehicle, but it behaves so in HL as well.

And regamedll claims to be GPL so I dunno how it's gonna work with hlsdk license.

Relying on Classify is quite a strange thing. It's gonna conflict with mods like Opposing Force that have additional classifications. But if it's how it's implemented in HL, then it's ok I guess.

FreeSlave commented 7 months ago

Found the proble with turnings: https://github.com/FWGS/hlsdk-portable/blob/2aebf12b1f18cbd695765c918bb36b1341783cd4/dlls/player.cpp#L1905 If stops train control when player strafes.

nekonomicon commented 7 months ago

@FreeSlave try the latest commit.

And regamedll claims to be GPL so I dunno how it's gonna work with hlsdk license.

It has exception, but IMHO It's very unclear. Anyway we can modify this code when valve released SDK update.

FreeSlave commented 7 months ago

Turn controls work fine after the latest change

N7P0L3ON commented 4 months ago

@nekonomicon any idea how to properly credit the player when he runs over / kills someone? The current implementation just takes 1 frag out of the one driving the func_vehicle for each kill... that might be desirable if you have it in Counter Strike and you're running over a teammate.. but what about if we push this to Half-Life? There it's free for all... and maybe for shits and giggles you need to get a point for fragging someone say with a forklift or other vehicle?

nekonomicon commented 4 months ago

@N7P0L3ON Why not ask Valve about that? Also, Half-Life has teamplay gamemode.

N7P0L3ON commented 4 months ago

@nekonomicon Thanks for the good suggestion. We got it fixed already.