FWGS / hlsdk-portable

Portable Half-Life SDK. GoldSource and Xash3D. Crossplatform.
https://xash.su
Other
266 stars 121 forks source link

Incorrect check for Xash3D on the server #439

Closed FreeSlave closed 6 months ago

FreeSlave commented 6 months ago

The bug introduced by https://github.com/FWGS/hlsdk-portable/commit/90193a938312d79ed5de611476c322c9101e9326

GoldSource (at least the current version) doesn't have sv_language cvar. So g_fIsXash3D is evaluated to true on GoldSource. Which stops the game with an error when a crossbow bolt hits a brush entity.

What we should decide is whether we need the special crossbow behavior and the check for the engine on the server at all. And if we need the check we should finally agree what it should be.

@a1batross @nekonomicon

a1batross commented 6 months ago

https://github.com/FWGS/hlsdk-portable/pull/440