search

FWGS / xash3d

DEPRECATED in favor of https://github.com/FWGS/xash3d-fwgs. Only bugfixes are accepted.
https://xash.su
GNU General Public License v3.0
554 stars 107 forks source link

The first player is getting lost when querying netinfo #241

Closed FreeSlave closed 7 years ago

FreeSlave commented 7 years ago

The problem is in this line https://github.com/FWGS/xash3d/blob/master/engine/server/sv_client.c#L766 count is written as char, so it adds terminating \0 when writing the first player (who has index 0).

a1batross commented 7 years ago

Seems to be fixed in current development branches: server-rework and build3598.

FreeSlave commented 7 years ago

No, it's the same in both branches https://github.com/FWGS/xash3d/blob/server-rework/engine/server/sv_client.c#L791 https://github.com/FWGS/xash3d/blob/build3598/engine/server/sv_client.c#L794

a1batross commented 7 years ago

My bad, did not noticed this before.

Fixed in https://github.com/FWGS/xash3d/commit/83868b1cad7df74998ebf2d958de222731241627.

FreeSlave commented 7 years ago

Seems to be ok now. Closing.