search

FWGS / xash3d

DEPRECATED in favor of https://github.com/FWGS/xash3d-fwgs. Only bugfixes are accepted.
https://xash.su
GNU General Public License v3.0
554 stars 107 forks source link

logo.avi not showing up in menus #243

Closed ma-choo closed 7 years ago

ma-choo commented 7 years ago

media\logo.avi doesn't show in menus on the latest release of Xash3D FWGS (0.18.1). My file's not corrupted, since I can have it play on startup by defining it in StartupVids.txt. It's just not showing up in the pause or launch menus anymore.

a1batross commented 7 years ago

At first, StartupVids.txt does not control the menu logo. It controls only the "startup" video, which is played during loading. Valve logo, Sierra logo and Gearbox logo, for example.

At second, logo.avi will not play, if you have Steam-style backgrounds. In any game, not only Half-Life.

ma-choo commented 7 years ago

I didn't want to to play the logo as a startup video, I was using that as an example to show that Xash3D can find media/logo.avi and that the file itself wasn't corrupted. But the logo wouldn't show up even when I was using a WON-style background.

I eventually found out it was the #ifdef USE_VFW statement in UI_DrawLogo function preventing logo.avi from playing. For whatever reason this always returns false in cl_menu.c, but it works fine in avikit.c (the only other place it's used). menu

avikit

Removing this statement makes the logo play in menus again.

a1batross commented 7 years ago

Fixed.

ma-choo commented 7 years ago

Oops. Just found out this was already fixed in 087c954. I was using an older version that didn't enable USE_VFW macro. Sorry. You can revert 0f0cf60.

a1batross commented 7 years ago

Nono, USE_VFW should not be outside avikit.c. Maybe someday avikit.c will be a part of current backend system.