FWeinb / grunt-svgstore

Merge svgs from a folder
MIT License
920 stars 94 forks source link

Bump grunt jshint to fix error that halts grunt task execution comple… #135

Closed roblevintennis closed 6 years ago

roblevintennis commented 6 years ago

I elected to do this on its own branch to keep my last PR single responsibility .. but the issue is when you run just grunt the jshint grunt task gives:

image

(I'm on a recent macbook if that matters).

As I know a bit about grunt, I was able to dev by doing grunt test directly, but, this will definitely trip up junior dev contributors.

With some googling I found folks saying to just upgrade: https://github.com/fians/Waves/issues/164

And that in fact fixed the issue for me after of course running npm install to get updated.