FX31337 / FX-BT-Scripts

:page_facing_up: Useful scripts for backtesting.
MIT License
34 stars 39 forks source link

Performance fixes (#37, #47, #51) #54

Closed kenorb closed 8 years ago

LemonBoy commented 8 years ago

Cherry pick #52 too

kenorb commented 8 years ago

CI fail with:

Traceback (most recent call last):
  File "/home/travis/build/FX31337/FX-BT-Scripts/convert_csv_to_mt.py", line 426, in <module>
    HST574(CSV(args.inputFile), outputPath, timeframe, symbol)
  File "/home/travis/build/FX31337/FX-BT-Scripts/convert_csv_to_mt.py", line 51, in __init__
    self._map_obj = mmap.mmap(self.path.fileno(), 0, prot=mmap.PROT_READ)
ValueError: cannot mmap an empty file
kenorb commented 8 years ago

@LemonBoy There was missing xargs variable. Fixed in b9b469d3eace3784efd06f4a7e07fa887b30d4df.

kenorb commented 8 years ago

I think the tests are fixed now in 119289959.

kenorb commented 8 years ago

You can try now to rebase with master.

LemonBoy commented 8 years ago

ehh, this is your branch, feel free to rebase it yourself

kenorb commented 8 years ago

Master is now passing fine, ok. I did rebase, but CI fails.

kenorb commented 8 years ago

Current CI results:

+python3 convert_csv_to_mt.py --help
Traceback (most recent call last):
  File "convert_csv_to_mt.py", line 68, in <module>
    class CSV(Input):
NameError: name 'Input' is not defined
make: *** [test-help] Error 1

You can checkout that branch in your fork and send another PR against master when it's fixed.

LemonBoy commented 8 years ago

sigh, the two speed improving PR are actually incompatible, hence why I recommended to run travis for each PR in it's own branch

kenorb commented 8 years ago

As part of your PR, you can try to revert the incompatible code, so once CI pass the tests, I can re-test on local again.

kenorb commented 8 years ago

@LemonBoy Is this branch still useful, or can be lost?

LemonBoy commented 8 years ago

You can safely delete this