FXIhub / condor

Condor: a simulation tool for flash X-ray imaging
http://lmb.icm.uu.se/condor
BSD 2-Clause "Simplified" License
25 stars 14 forks source link

Example PDB file does not match with spsim parsing of atomic number #14

Closed daurer closed 6 years ago

daurer commented 6 years ago

Since the spsim commit https://github.com/FilipeMaia/spsim/commit/fc920d802799376a47bfd4849a006b2698aa4d48#diff-573b39bd8d69627dd0431d425785abd0L200 columns 77-78 are parsed when searching for the atomic number in the PDB file. These columns don't exist in the example file DNA.pdb which causes the examples to be erratic.

A quick fix could be to use a complete PDB file instead. Even better would be to make spsim parse the atomic number in both cases (with and without the element columns 77-78), see https://github.com/FilipeMaia/spsim/issues/8

mhantke commented 6 years ago

Fixed with 92efad1876084a69c80be7bbecd2575c9ba80fa8.