FXIhub / condor

Condor: a simulation tool for flash X-ray imaging
http://lmb.icm.uu.se/condor
BSD 2-Clause "Simplified" License
25 stars 14 forks source link

Might want to enforce that input to NFFT has even dimensions #26

Open mhantke opened 4 years ago

mhantke commented 4 years ago

Your additional check_plan seems to reveal that nfft does not support odd number of pixels in any dimension.

Yes, you're right. Unfortunately the documentation doesn't tell that. But it's clear from the nfft sources.

Originally posted by @lozhnikov in https://github.com/FXIhub/condor/pull/21#issuecomment-649374411

mhantke commented 4 years ago

We might want to use the python package nfft instead of our own extension. I would like that because it would likely simplify installation and reduce maintenance.

@FilipeMaia, are you sure nfft supports multi-dimensional transforms?

FilipeMaia commented 4 years ago

@mhantke I saw you already posted in https://github.com/jakevdp/nfft/issues/2. Likely doesn't support although I didn't check the code yet.