search

FXIhub / hummingbird

Monitoring and Analysing flash X-ray imaging experiments
http://fxihub.github.io/hummingbird
BSD 2-Clause "Simplified" License
16 stars 14 forks source link

Use tornado.ioloop #142

Closed egorsobolev closed 1 year ago

egorsobolev commented 1 year ago

This replace pyzmq.eventloop.ioloop with tornado.ioloop.

eventloop.ioloop since is deprecated in pyzmq 17 and was removed in pyzmq 25 (released 12.01.2023)

This should work with tornado 3.0.0 (released in 2013) or later

FilipeMaia commented 1 year ago

Could you also remove or correct the comment just above, as it no longer is relevant?

egorsobolev commented 1 year ago

The test failed, because pyzmq.sugar.socket.Socket.fileno() is required by tornado but was added only in pyzmq 17. Could it possible to update pyzmq==17 and tornado==5 (or even newer, but libzmq also then) in the docker container filipemaia/hummingbird-testing?

FilipeMaia commented 1 year ago

It's not easy to update as it's based on an old psana image. But it's probably not relevant anymore. We have to check what's the current LCLS psana interface and update hummingbird accordingly.

On Mon, 6 Feb 2023 at 17:33, Egor Sobolev @.***> wrote:

The test failed, because pyzmq.sugar.socket.Socket.fileno() is required by tornado but was added only in pyzmq 17. Could it possible to update pyzmq==17 and tornado==5 (or even newer, but libzmq also then) in the docker container filipemaia/hummingbird-testing?

— Reply to this email directly, view it on GitHub https://github.com/FXIhub/hummingbird/pull/142#issuecomment-1419375230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABEC7XFD3L2XVBY6HY5AILWWERUJANCNFSM6AAAAAAUSMRHUA . You are receiving this because you modified the open/close state.Message ID: @.***>