search

FXMisc / Flowless

Efficient VirtualFlow for JavaFX
BSD 2-Clause "Simplified" License
185 stars 38 forks source link

Added option to change Scroll bars' policies; added corner #21

Closed JordanMartinez closed 8 years ago

JordanMartinez commented 8 years ago

With corner being added, I wasn't sure how to properly add the CSS file that would make its background color the same as the scrollbars background color. In RichTextFX, the color difference is still noticeable.

JordanMartinez commented 8 years ago

When building via gradle, I also get theses warnings when it's running the javadoc task:

Flowless/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java:33: 
    warning - Tag @see: can't find setHbarPolicy(ScrollBarPolicy) in org.fxmisc.flowless.VirtualizedScrollPane
Flowless/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java:38: 
    warning - Tag @see: can't find setVbarPolicy(ScrollBarPolicy) in org.fxmisc.flowless.VirtualizedScrollPane
Flowless/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java:33: 
    warning - Tag @see: can't find setHbarPolicy(ScrollBarPolicy) in org.fxmisc.flowless.VirtualizedScrollPane
Flowless/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java:38: 
    warning - Tag @see: can't find setVbarPolicy(ScrollBarPolicy) in org.fxmisc.flowless.VirtualizedScrollPane
TomasMikula commented 8 years ago

Wouldn't just setting the background color of the whole VirtualizedScrollPane solve the same problem as adding a corner node with that background color?

JordanMartinez commented 8 years ago

....lol.... Yeah, actually. Why didn't I think of that?

JordanMartinez commented 8 years ago

I've opened up #22 so that the scroll bar policy excludes the corner commits.